Make mainloop schedule type available as GemmKernel::Schedule
#1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishucsd
changed the title
GemmKernel::Schedule in all variantsGemmKernel::Schedule
manishucsd
changed the title
GemmKernel::ScheduleGemmKernel::Schedule
manishucsd
commented
Jul 17, 2024
| @@ -34,7 +34,7 @@ | |||
| #include <cutlass/library/types.h> | |||
| #include <cutlass/blas3_types.h> | |||
| #include <cutlass/gemm_coord.h> | |||
|
|
|||
| #include <stdexcept> | |||
There was a problem hiding this comment.
Include for std::runtime_error used in this file. This will allow us to include this file in other projects without have #include <stdexcept> above its include.
|
This PR has been labeled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes mainloop schedule uniformly available for mainloop variants. Our usage of this type involves additionally having it as a part of
GemmDescriptionobject for our kernels and decide mainloop variant at the dispatch time.This was already there in sm90_gemm_array_tma_warpspecialized_cooperative
cc: @IonThruster , @thakkarV , @hwu36 , @mnicely